Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SITES-28486 - [SLA3] Inconsistency in Inplace Editing Redirecting to Old Content Fragment Editor #2926

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

LSantha
Copy link
Contributor

@LSantha LSantha commented Mar 7, 2025

  • added karma tests for contentfragment editAction
Q                       A
Fixed Issues? SITES-28486
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0

…Old Content Fragment Editor

 * added karma tests for contentfragment editAction
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.17%. Comparing base (6b5248e) to head (9b9052c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2926   +/-   ##
=========================================
  Coverage     87.17%   87.17%           
  Complexity     2703     2703           
=========================================
  Files           235      235           
  Lines          7210     7210           
  Branches       1103     1103           
=========================================
  Hits           6285     6285           
  Misses          366      366           
  Partials        559      559           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LSantha
Copy link
Contributor Author

LSantha commented Mar 7, 2025

@rbartl-pv, can you check this PR? It's providing test coverage for your commit here a3ac4a5 .

@LSantha LSantha requested a review from vladbailescu March 7, 2025 11:30
Copy link
Contributor

@rbartl-pv rbartl-pv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

sonarqubecloud bot commented Mar 7, 2025

@LSantha LSantha merged commit e3d2944 into main Mar 7, 2025
14 checks passed
@LSantha LSantha deleted the SITES-28486 branch March 7, 2025 17:02
@LSantha LSantha added this to the 2.28.0 milestone Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants