Skip to content

Conversation

@moritzraho
Copy link
Member

Description

This may be considered a breaking change, as we are changing error codes.

  • avoid wrapping the error message returned by the server
  • differentiate unknown 4xx and 5xx
  • 403 => 401

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@shazron shazron merged commit d271e3c into main Nov 13, 2025
9 checks passed
@shazron shazron deleted the fix/error-codes branch November 13, 2025 08:46
@shazron shazron restored the fix/error-codes branch November 13, 2025 08:46
shazron added a commit that referenced this pull request Nov 13, 2025
shazron added a commit that referenced this pull request Nov 13, 2025
@shazron
Copy link
Member

shazron commented Nov 13, 2025

sorry, merged by mistake. Reverted, will push a new PR
#243

@shazron shazron mentioned this pull request Nov 13, 2025
10 tasks
@shazron
Copy link
Member

shazron commented Nov 13, 2025

Created #244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants