Skip to content

fix: list replication lag test failures #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2025
Merged

fix: list replication lag test failures #225

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96d1416
fix: list replication lag test failures
moritzraho Feb 14, 2025
d845cc3
Merge branch 'main' into fix/list-test-failures
moritzraho Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions e2e/e2e.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,11 @@ const putKeys = async (state, keys, { ttl, batchSize = 50 }) => {
}
const waitFor = (ms) => new Promise(resolve => setTimeout(resolve, ms))
const listAll = async (state, options = {}) => {
// since https://git.corp.adobe.com/CNA/adp-storage-state/pull/88 we are
// listing against a replica so we need to wait for the replica to be in sync
// to have exact results. The replication lag is about ~5ms, let's be
// conservative to avoid test failures.
waitFor(100)
const acc = []
for await (const { keys } of state.list(options)) {
acc.push(...keys)
Expand Down