Skip to content

Conversation

@shanejbrown
Copy link
Contributor

What does this PR do?

Add support to buildrunner for build secrets. For more info see: https://docs.docker.com/build/building/secrets/

What issues does this PR fix or reference?

Previous Behavior

New Behavior

Merge requirements satisfied?

  • I have updated the documentation or no documentation changes are required.
  • I have added tests to cover my changes.
  • I have updated the base version in BASE_VERSION (if appropriate).

@shanejbrown shanejbrown force-pushed the secrets branch 6 times, most recently from 17a544d to 65fb65a Compare April 14, 2025 20:49
@shanejbrown
Copy link
Contributor Author

There is a problem running examples/build/secrets/platforms-buildrunner.yaml in github actions but it does work on my local machine. I get this error when it is ran in github exec /bin/sh: exec format error. So I am excluding examples/build/secrets/platforms-buildrunner.yaml from being ran in tests. If this is a problem in our build environment we can revisit this error.

@shanejbrown shanejbrown merged commit 3a7ce7c into adobe:main Apr 14, 2025
15 of 18 checks passed
@bluesliverx
Copy link
Contributor

There is a problem running examples/build/secrets/platforms-buildrunner.yaml in github actions but it does work on my local machine. I get this error when it is ran in github exec /bin/sh: exec format error. So I am excluding examples/build/secrets/platforms-buildrunner.yaml from being ran in tests. If this is a problem in our build environment we can revisit this error.

Interesting... I usually see that when I try to mix x86 images with ARM machines, etc, but I'm not sure how that would apply here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants