Skip to content

Fix issues with no-cache flag and new builder #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025
Merged

Fix issues with no-cache flag and new builder #211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions buildrunner/docker/multiplatform_image_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ def _build_single_image(
target: str,
build_args: dict,
inject: dict,
cache: bool = False,
cache: Optional[bool] = None,
pull: bool = False,
secrets: Optional[List[str]] = None,
) -> None:
Expand Down Expand Up @@ -323,7 +323,8 @@ def _build_single_image(
build_kwargs = {}
if builder:
build_kwargs["builder"] = builder
if cache:
# Handle both no cache and cache
if cache is not None:
build_kwargs["cache"] = cache
if pull:
build_kwargs["pull"] = pull
Expand Down Expand Up @@ -406,7 +407,7 @@ def build_multiple_images(
use_threading: bool = True,
build_args: dict = None,
inject: dict = None,
cache: bool = False,
cache: Optional[bool] = None,
pull: bool = False,
secrets: Optional[List[str]] = None,
) -> BuiltImageInfo:
Expand Down
Loading