Skip to content

fix(SITES-16796) Image Missing Alt Text #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ens84646 wants to merge 3 commits into from
Closed

fix(SITES-16796) Image Missing Alt Text #328

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b6290e
Changing aria-label to menubar-item title and adding alt to coral-icon.
TeodorEns Nov 23, 2023
9b7f20b
Checking if coral-icon exists in order to add to alt attribute.
TeodorEns Nov 27, 2023
1a1a1c3
Changed aria-label depending on title.
TeodorEns Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion coral-component-shell/src/scripts/ShellMenuBarItem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ class ShellMenuBarItem extends BaseComponent(HTMLElement) {
// providing aria-label will correctly pass it on to the shell menu button child element.
if (name === 'aria-label') {
if (value && this._elements.shellMenuButton.textContent.trim() === '') {
this._elements.shellMenuButton.setAttribute('aria-label', value);
this._elements.shellMenuButton.setAttribute('aria-label', this.title ? this.title : value);
}
} else {
super.attributeChangedCallback(name, oldValue, value);
Expand Down Expand Up @@ -418,6 +418,10 @@ class ShellMenuBarItem extends BaseComponent(HTMLElement) {
if (this.menu !== null) {
this.menu = this.menu;
}

if (this._elements.shellMenuButton.getElementsByTagName('coral-icon')[0]) {
this._elements.shellMenuButton.getElementsByTagName('coral-icon')[0].setAttribute('alt', this.title);
}
}

/**
Expand Down