Skip to content

fix(Accessibility) Image Missing Alt Text #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

fix(Accessibility) Image Missing Alt Text #342

Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
8aa6ed4
added alt attribute with title value
StoianLucian Mar 21, 2024
5c7f7de
added semicolon
StoianLucian Mar 21, 2024
b6f295b
changed queryselector
StoianLucian Mar 21, 2024
1ad51e9
added nextFrame
StoianLucian Mar 21, 2024
78d7ab9
removed variable
StoianLucian Mar 21, 2024
63dd822
removed variable
StoianLucian Mar 21, 2024
3e2cafb
set variable
StoianLucian Mar 25, 2024
6d2b4c1
removed condition
StoianLucian Mar 25, 2024
8789d1f
added null check
StoianLucian Mar 25, 2024
b101446
removed double selector
StoianLucian Mar 25, 2024
8029321
-
StoianLucian Mar 25, 2024
e20a85e
-
StoianLucian Mar 25, 2024
c65e2a4
-
StoianLucian Mar 25, 2024
90128aa
test
StoianLucian Mar 25, 2024
46ac5aa
test
StoianLucian Mar 25, 2024
ff39317
added null check
StoianLucian Mar 25, 2024
f94f7e8
removed whitespaces
StoianLucian Mar 25, 2024
555e68b
removed null check
StoianLucian Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion coral-component-shell/src/scripts/ShellMenuBarItem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ class ShellMenuBarItem extends BaseComponent(HTMLElement) {
// providing aria-label will correctly pass it on to the shell menu button child element.
if (name === 'aria-label') {
if (value && this._elements.shellMenuButton.textContent.trim() === '') {
this._elements.shellMenuButton.setAttribute('aria-label', value);
this._elements.shellMenuButton.setAttribute('aria-label', this.title ? this.title : value);
}
} else {
super.attributeChangedCallback(name, oldValue, value);
Expand Down Expand Up @@ -418,6 +418,12 @@ class ShellMenuBarItem extends BaseComponent(HTMLElement) {
if (this.menu !== null) {
this.menu = this.menu;
}

let shellMenuButtonIcon = this._elements.shellMenuButton.getElementsByTagName('coral-icon')[0];

if(shellMenuButtonIcon) {
shellMenuButtonIcon.setAttribute('alt', this.title);
}
}

/**
Expand Down