Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Playwright runs #307

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Fix Playwright runs #307

merged 1 commit into from
Dec 19, 2024

Conversation

bosschaert
Copy link
Contributor

@bosschaert bosschaert commented Dec 19, 2024

Description

The Playwright runs have been failing in the github actions during the execution of
npx playwright install --with-deps
with a missing dependency.

See here: https://github.com/adobe/da-live/actions/runs/12400574999/job/34618070050#step:5:43

Moving up the Playwright version to the latest.

Test URLs:

Motivation and Context

We want the Playwright tests to run again.

How Has This Been Tested?

This is an update to the testing system. It works locally.

Types of changes

Just a change in the testing system.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

The Playwright runs have been failing in the github actions during the
execution of
  npx playwright install --with-deps
with a missing dependency.
Moving up the Playwright version to the latest.
Copy link

aem-code-sync bot commented Dec 19, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@bosschaert bosschaert mentioned this pull request Dec 19, 2024
10 tasks
Copy link

aem-code-sync bot commented Dec 19, 2024

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@chrischrischris chrischrischris merged commit a2e87bd into main Dec 19, 2024
9 of 10 checks passed
@chrischrischris chrischrischris deleted the fixpw branch December 19, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants