Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize uploaded file path #325

Merged
merged 2 commits into from
Jan 18, 2025
Merged

Sanitize uploaded file path #325

merged 2 commits into from
Jan 18, 2025

Conversation

rgclayton
Copy link
Contributor

Sanitize uploaded files path:

  • Replace non-standard characters in uploaded file path with -.
  • RegEx to only allow a-z, A-Z, 0-9, and period in file path.

Motivation and Context

Resolves: #309

How Has This Been Tested?

Manual/Unit test created

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

auniverseaway
auniverseaway approved these changes Jan 18, 2025
View reviewed changes
Copy link
Member

@auniverseaway auniverseaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

@auniverseaway auniverseaway merged commit 77a78fc into adobe:main Jan 18, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auniverseaway auniverseaway auniverseaway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sanitize upload names
2 participants
@rgclayton @auniverseaway