Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-75 - Don't display own user in awareness icon list #76

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

bosschaert
Copy link
Contributor

Description

The current user should not be displayed in the awareness icon list.

Related Issue

Fixes: #75

Motivation and Context

Reduces clutter in the awareness icons list.

How Has This Been Tested?

Unit test added and also tested manually on Chrome and Firefox.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed (except for the ones that were already failing)

Copy link

aem-code-sync bot commented Mar 6, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@auniverseaway auniverseaway merged commit 5fd5709 into main Mar 7, 2024
3 of 4 checks passed
@auniverseaway auniverseaway deleted the filter-user branch March 7, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't show own logged in used in awareness icon list
2 participants