Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-110647:Updated the imsurl in the documentation #75

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

maniskum
Copy link
Contributor

@maniskum maniskum commented Aug 8, 2024

Summary

Update the ims url in the documentation

Related Issue

Changes

  • Update the ims url in the documentation

Relevant Documentation

Please enter the links of any docs updated to reflect this change

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@maniskum maniskum force-pushed the CORE-110647 branch 2 times, most recently from 1963507 to df0bc8e Compare August 12, 2024 06:35
Copy link
Collaborator

@vivetiwa vivetiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment please take a look.

1. key: `x-adobe-flow-id`, value: `341fd4f0-cdec-4912-1ab6-fb54aeb41286`
2. key: `x-adobe-dataset-id`, value: `3096fbfd5978431948af3ba3`


`aep.connection.auth.endpoint` value for prod
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please move aep.connection.auth.endpoint outside aep.connection.endpoint.headers block? We can add bullet to clearly differentiate between aep.connection.endpoint.headers and aep.connection.auth.endpoint

@maniskum maniskum force-pushed the CORE-110647 branch 4 times, most recently from bc5499a to 74a0ebd Compare August 12, 2024 10:10
@vivetiwa vivetiwa merged commit 2e8665d into adobe:master Aug 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants