Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address no data glitch issue #65

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Address no data glitch issue #65

wants to merge 2 commits into from

Conversation

dbrrt
Copy link
Contributor

@dbrrt dbrrt commented Jan 26, 2024

@dbrrt dbrrt requested a review from MarquiseRosier January 26, 2024 16:33
Copy link

aem-code-sync bot commented Jan 26, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Collaborator

@MarquiseRosier MarquiseRosier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update this PR to ensure Progress Bar Component stays until the data replaces it? :) That's about the only change needed here for me to approve because I'm sure people will complain about the blank screen with no indication of the fact that data is loading!

@dbrrt
Copy link
Contributor Author

dbrrt commented Feb 1, 2024

Can you update this PR to ensure Progress Bar Component stays until the data replaces it? :) That's about the only change needed here for me to approve because I'm sure people will complain about the blank screen with no indication of the fact that data is loading!

My thought on this issue is that it was related to how "fetching" to passed to children components, so not something that can be addressed directly, but instead fixing how fetching is being integrated via props.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] No result glitch before actual data is loaded
2 participants