Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the word visits to page views #97

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

langswei
Copy link
Collaborator

@langswei langswei commented Apr 29, 2024

Replaced the term "visits" with "page views" for consistency.

@lydiapuric was not able to approve in a way that allowed a merge, @MarquiseRosier to approve after his PTO - not urgent!

Old: https://data.aem.live
New: https://remove-visits--franklin-dashboard--adobe.hlx.live/

Copy link

aem-code-sync bot commented Apr 29, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@langswei langswei requested a review from lydiapuric April 29, 2024 15:05
Copy link

aem-code-sync bot commented Apr 29, 2024

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

@lydiapuric lydiapuric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@langswei langswei requested a review from MarquiseRosier April 29, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants