fix: add dark mode support for UE-Trial modal dialogs#1063
Merged
Conversation
|
Dark mode overrides for modals (appended to document.body, outside .ue-trial) cannot be scoped under .ue-trial, so disable the rule for the dark mode override section.
aem-code-sync
Bot
temporarily deployed
to
fix/ue-trial-dark-mode-modals
aem-code-sync
Bot
temporarily deployed
to
fix/ue-trial-dark-mode-modals
|
Almost :) the final dialog is still white: |
The dark mode override had the same specificity as the base rule but appeared earlier in the file, so the base rule won. Moved it to appear after the base rule so it correctly overrides in dark mode.
mhaack
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--color-gray-*CSS variables and:where(html[data-theme="dark"])pattern for consistency with the rest of the siteFixes #1062
Test plan