Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update v2 of experimentation engine #595

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

feat: update v2 of experimentation engine #595

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a75a73d
remove old experimentation engine before adding v2
FentPams Jun 26, 2024
48ebaba
Merge commit 'cd1801975824a72f71f2425259d35d0617a050c1' as 'plugins/e…
FentPams Jun 26, 2024
cd18019
Squashed 'plugins/experimentation/' content from commit 638e0db
FentPams Jun 26, 2024
d573b87
Revert package.json and package-lock.json to match main branch
FentPams Jun 27, 2024
23b2747
update condition on adding experimentation plugin
FentPams Jul 6, 2024
62c766c
add document eventlistner for properly decorate fragments
FentPams Jul 6, 2024
3257e04
update createAudience
FentPams Jul 7, 2024
cd65939
support flexible parsing
FentPams Jul 22, 2024
2b9ad86
Squashed 'plugins/experimentation/' changes from 638e0db..f7c45aa
FentPams Jul 23, 2024
81d2ac5
update plugin add condition
FentPams Jul 23, 2024
155082e
Squashed 'plugins/experimentation/' changes from f7c45aa..942948d
FentPams Aug 7, 2024
d4c28c1
update to the latest v2
FentPams Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/scripts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ window.hlx.plugins.add('performance', {

window.hlx.plugins.add('experimentation', {
condition: () => document.head.querySelector('[name^="experiment"],[name^="campaign-"],[name^="audience-"]')
|| document.head.querySelector('[property^="campaign:-"],[property^="audience:-"]')
|| document.head.querySelector('[property^="campaign:-"],[property^="audience:-"],[property^="campaign-"],[property^="audience-"]')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually, it's <meta property="campaign:-…"> or <meta name="campaign-…">, property without : is something I haven't encountered yet.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right. I added that because I was thinking the user could omit the :, and declare as Audience Desktop. Then I realized it is better to have the norm that : should be required. I will revert this.

For <meta property="campaign:-..>, I am going to remove the hyphen here too, and only keep [property^="campaign:"],[property^="audience:"]. As the hyphen comes from the space, and should not considered as the condition.

|| document.querySelector('.section[class*="experiment-"],.section[class*="audience-"],.section[class*="campaign-"]')
|| [...document.querySelectorAll('.section-metadata div')].some((d) => d.textContent.match(/Experiment|Campaign|Audience/i)),
options: { audiences: AUDIENCES },
Expand Down
Loading