feat: Help for facets #756
Open
+224
−123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For initial review, added help to explorer.html view only for now. Can be replicated to other views post review. |
|
@asthabh23 Not sure if it is me, but the UI (RUM explorer) is broken in my browser. Can you please take a look ? 
|
vdua
reviewed
Jan 17, 2025
| display: none; | ||
| footer.footer-wrapper.appear { | ||
| display: none; | ||
| } |
There was a problem hiding this comment.
The footer should be hidden always. That is the reason for the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds help icon to the facets on explorer and oversight and adds link to the respective sections of official documentation.
Related Issue
#755
Motivation and Context
For easy understanding of the use of different facets on RUM Dashboard
How Has This Been Tested?
Explorer:
https://main--helix-website--adobe.aem.page/tools/rum/explorer.html?domain=emigrationbrewing.com&filter=&view=month&metrics=all&domainkey=open
vs
https://facets-help--helix-website--adobe.aem.page/tools/rum/explorer.html?domain=emigrationbrewing.com&filter=&view=month&metrics=all&domainkey=open
Oversight:
https://main--helix-website--adobe.aem.page/tools/oversight/explorer.html?domain=emigrationbrewing.com&filter=&view=month&metrics=all&domainkey=open
vs
https://facets-help--helix-website--adobe.aem.page/tools/oversight/explorer.html?domain=emigrationbrewing.com&filter=&view=month&metrics=all&domainkey=open
Screenshots (if appropriate):
Types of changes
Checklist: