Skip to content

Conversation

@bensi94
Copy link
Contributor

@bensi94 bensi94 commented Oct 30, 2025

Description

Adds a new --allow-unicode flag to control Unicode character handling in YAML output:

  • CLI flag: --allow-unicode (default: False) - preserves Unicode characters instead of escaping them
  • Python API: allow_unicode parameter in ConfigProcessor.process()
  • Config merger: --allow-unicode flag support in himl-config-merger

Includes comprehensive tests (11 new tests covering multiple languages) and documentation with practical examples.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test improvement

Testing

  • Tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested the changes manually

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Notes

I may not have full context of this project's design decisions. If this approach doesn't align with the project's direction, I'd be grateful for feedback or suggestions for a better alternative. Thank you for maintaining this project! 🙏

@bensi94
Copy link
Contributor Author

bensi94 commented Nov 3, 2025

@amuraru or @dobrerazvan

Could you take a look when you have a chance? 🙏

README.md Outdated
exclude_keys=exclude_keys,
output_format=output_format,
print_data=True
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep this reformat out of the PR to reduce the number of changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Fixed now.

README.md Outdated
output_format=output_format,
print_data=True,
type_strategies=[(list, [strategy_merge_override, 'append']), (dict, ["merge"])]
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Fixed now.

@amuraru
Copy link
Contributor

amuraru commented Nov 3, 2025

please see my cosmetic change request above - otherwise looks good to me. Thank you for your contribution!

@bensi94
Copy link
Contributor Author

bensi94 commented Nov 3, 2025

Thanks, comments have been addressed.

@codecov
Copy link

codecov bot commented Nov 3, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@amuraru amuraru merged commit 005c8f2 into adobe:main Nov 4, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants