-
Notifications
You must be signed in to change notification settings - Fork 33
feat: add --allow-unicode flag for Unicode character handling #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Could you take a look when you have a chance? 🙏 |
README.md
Outdated
| exclude_keys=exclude_keys, | ||
| output_format=output_format, | ||
| print_data=True | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's keep this reformat out of the PR to reduce the number of changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Fixed now.
README.md
Outdated
| output_format=output_format, | ||
| print_data=True, | ||
| type_strategies=[(list, [strategy_merge_override, 'append']), (dict, ["merge"])] | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Fixed now.
|
please see my cosmetic change request above - otherwise looks good to me. Thank you for your contribution! |
|
Thanks, comments have been addressed. |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Description
Adds a new --allow-unicode flag to control Unicode character handling in YAML output:
Includes comprehensive tests (11 new tests covering multiple languages) and documentation with practical examples.
Type of Change
Testing
Checklist
Additional Notes
I may not have full context of this project's design decisions. If this approach doesn't align with the project's direction, I'd be grateful for feedback or suggestions for a better alternative. Thank you for maintaining this project! 🙏