Skip to content

Conversation

@sfotony
Copy link
Contributor

@sfotony sfotony commented Oct 21, 2025

Description

Futher iterates the MaxParkedNodes feature by allowing parking a percentage of the total cluster size at a time. This also makes parking occur in the order that he nodes were created in, oldest first.

Motivation and Context

This allows better flexiblity around regulating how aggressive the overall parking process is. The change in ordering ensures that the oldest nodes are removed first (as evictions allow).

How Has This Been Tested?

Unit tests were updated to reflect how it functions now.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sfotony sfotony requested a review from a team as a code owner October 21, 2025 01:06
@sfotony sfotony changed the title Max parked nodes percentage Max parked nodes by using percentages Oct 21, 2025
Copy link

@JonnieDoe JonnieDoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sfotony sfotony merged commit 54b2501 into adobe:main Oct 23, 2025
6 checks passed
sfotony added a commit to sfotony/k8s-shredder that referenced this pull request Oct 24, 2025
* Allow MaxParkedNodes to work with percentages

* Park nodes by ago, oldest first
sfotony added a commit that referenced this pull request Oct 24, 2025
* Allow MaxParkedNodes to work with percentages

* Park nodes by ago, oldest first
sfotony added a commit to sfotony/k8s-shredder that referenced this pull request Oct 24, 2025
* Allow MaxParkedNodes to work with percentages

* Park nodes by ago, oldest first
@sfotony sfotony mentioned this pull request Oct 25, 2025
10 tasks
sfotony added a commit that referenced this pull request Oct 25, 2025
* Allow MaxParkedNodes to work with percentages

* Park nodes by ago, oldest first
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants