liveness/readiness probe for Kraft controllers #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvan
commented
Aug 13, 2025
| b := broker.ReadOnlyConfig | ||
| trimmedConfig := strings.TrimSpace(b) | ||
|
|
||
| if strings.Contains(trimmedConfig, kafkautils.KafkaConfigSecurityInterBrokerProtocol+"=") { |
Collaborator
Author
There was a problem hiding this comment.
Change is unrelated to the health check. Just removing unnecessary logging.
dobrerazvan
reviewed
Aug 18, 2025
hvan
changed the title
dobrerazvan
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to address an issue where a KRaft controller was shutting down, but the pod was never restarted. By adding readiness/liveness probe to the kafka container (for Kraft controllers only), if these probes fail, the pod will restart automatically.
For readiness probe, we will check the controller listener port using TCP. When this port is open, the kafka container is ready for communication with other controllers.
For liveness probe, we will check the current-state metric provided by a JMX bean. The expected state is 'leader' or 'follower'. For any other states, we will consider it to be unhealthy.
Type of Change
Checklist