-
Notifications
You must be signed in to change notification settings - Fork 15
Upgrade jmx-exporter to v1.5.0 #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dafe225 to
04d55a5
Compare
d0876a7 to
84fe514
Compare
84fe514 to
388b0d6
Compare
211d5df to
33fdc50
Compare
33fdc50 to
ec61bcc
Compare
92e9a36 to
695620e
Compare
647ac5f to
5f449a0
Compare
bc5898c to
d38a92c
Compare
a354dcb to
527226f
Compare
670659a to
8a79e77
Compare
|
|
||
| WORKDIR /src | ||
| RUN mvn -B -Dmaven.javadoc.skip=true -Dskip.javadoc=true \ | ||
| -Dmaven.compiler.source=21 -Dmaven.compiler.target=21 -Dmaven.compiler.release=21 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not using https://hub.docker.com/r/bitnami/jmx-exporter and docker-hub-remote mirror?
@dobrerazvan the main reason is that I want to align the compilation of jmx_exporter with the same jre target as the kafka itself (i.e java 21). this is an agent attached to the actual broker so I think it's better to control the built of that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, didn't think of that.
8872603 to
8851c74
Compare
Build jmx_exporter from upstream prometheus releases. Currently the jmx-javaagent docker image is built from https://github.com/amuraru/jmx_exporter In order to bring that dependency in-tree here, this PR extends kafka image(s) release (kafka-*) action to also build a docker image directly from https://github.com/prometheus/jmx_exporter The image is published to: https://github.com/adobe/koperator/pkgs/container/koperator%2Fjmx-javaagent
Currently the jmx-javaagent docker image is built from https://github.com/amuraru/jmx_exporter (and it's an old/unmantained version)
In order to bring that dependency in-tree here, this PR extends kafka image(s) release (kafka-*) action to also build a docker image directly from https://github.com/prometheus/jmx_exporter
The image is published to:
https://github.com/adobe/koperator/pkgs/container/koperator%2Fjmx-javaagent