Kraft #74
Merged
Kraft #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pgrade triggered by controller addition/removal
…ting ClusterID in status
…aicloud#1002) * Add ConcurrentBrokerRestartCountPerRack to RollingUpgradeConfig
* Allow setting CLUSTER_ID as env var for zk to kraft migration * Add migration properties to control if broker are in kraft mode or zk mode even when kraft is enabled * Refactor functions and additional test cases * Fix linting * Fix unit test * Add zkConnect property when broker is in zk mode * Remove control.plane.listener.name property from broker during migration * Add additional labels to brokers for backward compatibility while performing migration
… and check for security.inter.broker.protocol (#101) * adding fix for koperator to add interBrokerListenerName one at a time * updating test to include inter.broker.listener.name * fixing code that checks for inter.broker.listener.name * removing unecessary function calls * updating test expectations to be alphabetized * adding generateListenerSpecificConfig back * adding merges back in * reverting back to having getConfigProperties only call generateListenerSpecificConfig * removing unnecessary comments --------- Co-authored-by: Cameron Wright <[email protected]>
* [CORE-122420] - Update pod name for Kraft Controllers * Triggering Integration Tests * Update Test Case --------- Co-authored-by: Daniel Vaseekaran <[email protected]>
dobrerazvan
commented
May 22, 2025
dobrerazvan
commented
May 22, 2025
dobrerazvan
commented
May 22, 2025
dobrerazvan
commented
May 22, 2025
Co-authored-by: Razvan Dobre <[email protected]>
Co-authored-by: Razvan Dobre <[email protected]>
…ly nodes in kraft mode only (#104) * fixing controller reconcile logic that was stopping all reconciles * fixing lint issue * fixing filteredBrokerID changes * Updating spacing in cctask_controller_test * increasing timeout time during waitforclusterrunningstate * testing longer pull rate * increasing serviceIP range to try to increase test stability * reverting to 50ms * adding service counter to try and further debug * temporarily removing counter * removing commented section * dummy commit to kick of test * Adding if statement to check if kafkacluster is deleted first before deleting in test * adding additional checks and defering if an error arises to help with debugging * adding further debugging and using a helper function to clean up kafkacluster resources * adding new util to help with safer deleting, easier debugging, and an additional helper function for port management * taking out old tests * adding liscense text to new test_utils.go * taking out old comments from previous testing * fixing lint errors * handling errors * adding panic handling for problematic tests * adding defer to exact spot where panic is occuring * removing safekafkacleanup * removing cleanups * adding logging to help with debug * adding printf formatting directive * adding removal for kafkacluster kraft specific test * changing kfakcluster deletion * taking out manual kraft cleanup * removing manual cleanup of kafkacluster * refactoring externalnodeport test to be more stable * fixing license issue * removing logging * changing logging * getting rid of old comments * updating test to reserve all ports in a line * fixing lint issue * fixing lint issues * Update controllers/tests/suite_test.go Co-authored-by: hvan <[email protected]> * fixing lint errors * forcing ordering to further prevent nodeport collision --------- Co-authored-by: Cameron Wright <[email protected]> Co-authored-by: hvan <[email protected]>
dobrerazvan
commented
May 27, 2025
dobrerazvan
commented
May 27, 2025
controllers/tests/kafkacluster_controller_externallistenerbindings_test.go
Outdated
Show resolved
Hide resolved
dobrerazvan
commented
May 27, 2025
dobrerazvan
commented
May 27, 2025
dobrerazvan
commented
May 27, 2025
dobrerazvan
commented
Jun 3, 2025
Co-authored-by: Razvan Dobre <[email protected]>
Co-authored-by: Razvan Dobre <[email protected]>
Co-authored-by: Razvan Dobre <[email protected]>
dvaseekara
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please provide a meaningful description of what this change will do, or is for. Bonus points for including links to
related issues, other PRs, or technical references.
Note that by not including a description, you are asking reviewers to do extra work to understand the context of this
change, which may lead to your PR taking much longer to review, or result in it not being reviewed at all.
Type of Change
Checklist