chore: Update to Node 20 #6385
Open
chore: Update to Node 20 #6385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
devongovett
force-pushed
the
main
branch
2 times, most recently
from
8cb1a5d to
3013156
Compare
1 similar comment
devongovett
force-pushed
the
main
branch
2 times, most recently
from
a79adcf to
3013156
Compare
yep, that's the same one I was getting. I'm not sure why the resolver isn't working... |
# Conflicts: # package.json # yarn.lock
snowystinger
commented
Dec 1, 2024
| @@ -108,6 +108,19 @@ class NumberParserImpl { | |||
|
|
|||
| constructor(locale: string, options: Intl.NumberFormatOptions = {}) { | |||
| this.locale = locale; | |||
| // see https://tc39.es/ecma402/#sec-setnfdigitoptions, when using roundingIncrement, the maximumFractionDigits and minimumFractionDigits must be equal | |||
There was a problem hiding this comment.
note, this previously threw in Chrome and Node 22
new Intl.NumberFormat('en-US', {roundingIncrement: 2})
# Conflicts: # yarn.lock
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6380
Not sure why, but the SSR tests are taking longer in node 20, long enough that I had to extend the time allocated and I chose to run them in band so that the concurrency wouldn't slow them down.
Everything else is working though.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: