chore: Update to Node 20 #6385
chore: Update to Node 20 #6385
Conversation
1 similar comment
devongovett
force-pushed
the
main
branch
2 times, most recently
from
8cb1a5d to
3013156
Compare
1 similar comment
devongovett
force-pushed
the
main
branch
2 times, most recently
from
a79adcf to
3013156
Compare
There was a problem hiding this comment.
Running make website-production right now, but otherwise I'm not sure I have enough background about the changes made in this PR.
EDIT: Got the following error when running make website-production, I assume that was expected from the comment in your description?
@parcel/transformer-postcss: Could not resolve module
"@spectrum-css/component-builder/css/processors" from
"/private/var/folders/s9/z051ddk558z1778tc9fx1n380000gq/T/177329403da46b96590bfd204cd422a6/postcss.config.js"
| @@ -34,7 +34,7 @@ module.exports = { | |||
| 'packages/' | |||
| ], | |||
|
|
|||
| testTimeout: 30000, | |||
| testTimeout: 50000, | |||
There was a problem hiding this comment.
oof, was it the SSR tests you mentioned that prompted this?
There was a problem hiding this comment.
yeah, I'm not sure why they take longer now
There was a problem hiding this comment.
attempting to fix with maxConcurrency instead, might just be something with how node does concurrency now
There was a problem hiding this comment.
spectrum-css/builder had a whole bunch of dependencies we weren't making use of, even transitively, so I got rid of them by making the temp version
it also allowed me to get rid of a patch
yep, that's the same one I was getting. I'm not sure why the resolver isn't working... |
# Conflicts: # package.json # yarn.lock
| @@ -108,6 +108,19 @@ class NumberParserImpl { | |||
|
|
|||
| constructor(locale: string, options: Intl.NumberFormatOptions = {}) { | |||
| this.locale = locale; | |||
| // see https://tc39.es/ecma402/#sec-setnfdigitoptions, when using roundingIncrement, the maximumFractionDigits and minimumFractionDigits must be equal | |||
There was a problem hiding this comment.
note, this previously threw in Chrome and Node 22
new Intl.NumberFormat('en-US', {roundingIncrement: 2})
# Conflicts: # yarn.lock
Closes #6380
Not sure why, but the SSR tests are super brittle now. In addition, I haven't gotten the
make website-productionworking locally, would love someone else to run those as well.Just make sure every terminal you open is set to node 20.15.0
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: