Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for react 19 #7489

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

for react 19 #7489

wants to merge 4 commits into from

Conversation

lerte
Copy link

@lerte lerte commented Dec 6, 2024

the peerDependencies of use-sync-external-store 1.4.0 is "react": "^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0"

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

the peerDependencies of use-sync-external-store 1.4.0 is "react": "^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0"
Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you sign the CLA then close and re-open this to trigger a new passing build

@snowystinger
Copy link
Member

The bump is within the range allowed, what was the issue you found?

@lerte lerte closed this Dec 7, 2024
@lerte lerte reopened this Dec 7, 2024
@lerte lerte closed this Dec 7, 2024
@lerte lerte reopened this Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants