chore: Update TreeView API #7613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
reviewed
Jan 22, 2025
| children | ||
| } = props; | ||
| let {isDetached, isEmphasized} = useContext(InternalTreeContext); | ||
| let {hasChildItems} = useContext(TreeItemContext); |
There was a problem hiding this comment.
hasChildRows in the render props doesn't give you what you need?
There was a problem hiding this comment.
apparently i do need this right now, I'll look into it more tomorrow
There was a problem hiding this comment.
I believe it is for the case where you want to mark a TreeRow as expandable despite not having any child rows (aka async case/permissions case where the user doesn't have access to said TreeRow's content but needs to know that it is expanded)
There was a problem hiding this comment.
yeah, was just looking into it and was scratching my head why this was needed and clearly intentional because there are tests for it as well
There was a problem hiding this comment.
Probably should be done in RAC then. This won't result in the right aria attributes being added, only the visual chevron appearing. There is a hasChildNodes property internally, maybe that should be used instead?
LFDanLu
reviewed
Jan 25, 2025
devongovett
previously approved these changes
Jan 28, 2025
LFDanLu
previously approved these changes
Jan 29, 2025
snowystinger
dismissed stale reviews from LFDanLu and devongovett
The base branch was changed.
snowystinger
force-pushed
the
s2-treeview-api-update
branch
from
23a6b1a to
04adce4
Compare
5 tasks
* fix logic to determine hasChildNodes * revert breaking changes but use prop override
# Conflicts: # packages/@react-spectrum/s2/src/TreeView.tsx
devongovett
reviewed
Feb 12, 2025
devongovett
previously approved these changes
Feb 12, 2025
reidbarber
reviewed
Feb 12, 2025
Yeah, bad merge, thanks for catching. I've run chromatic on the PR now. Should be all good. |
## API Changes
react-aria-components/react-aria-components:UNSTABLE_TreeItem UNSTABLE_TreeItem <T extends {}> {
aria-label?: string
children: ReactNode
className?: string | ((TreeItemRenderProps & {
defaultClassName: string | undefined
})) => string
download?: boolean | string
+ hasChildItems?: boolean
href?: Href
hrefLang?: string
id?: Key
onHoverChange?: (boolean) => void
onHoverStart?: (HoverEvent) => void
ping?: string
referrerPolicy?: HTMLAttributeReferrerPolicy
rel?: string
routerOptions?: RouterOptions
style?: CSSProperties | ((TreeItemRenderProps & {
defaultStyle: CSSProperties
})) => CSSProperties | undefined
target?: HTMLAttributeAnchorTarget
textValue: string
value?: {}
}/react-aria-components:TreeItemProps TreeItemProps <T = {}> {
aria-label?: string
children: ReactNode
className?: string | ((TreeItemRenderProps & {
defaultClassName: string | undefined
})) => string
download?: boolean | string
+ hasChildItems?: boolean
href?: Href
hrefLang?: string
id?: Key
onHoverChange?: (boolean) => void
onHoverStart?: (HoverEvent) => void
ping?: string
referrerPolicy?: HTMLAttributeReferrerPolicy
rel?: string
routerOptions?: RouterOptions
style?: CSSProperties | ((TreeItemRenderProps & {
defaultStyle: CSSProperties
})) => CSSProperties | undefined
target?: HTMLAttributeAnchorTarget
textValue: string
value?: T
}/react-aria-components:TreeItemContentRenderProps TreeItemContentRenderProps {
allowsDragging?: boolean
- hasChildRows: boolean
+ hasChildItems: boolean
id: Key
isDisabled: boolean
isDragging?: boolean
isDropTarget?: boolean
isFocusVisible: boolean
isFocusVisibleWithin: boolean
isFocused: boolean
isHovered: boolean
isPressed: boolean
isSelected: boolean
level: number
selectionBehavior: SelectionBehavior
selectionMode: SelectionMode
state: TreeState<unknown>
}@react-aria/gridlist/@react-aria/gridlist:AriaGridListItemOptions AriaGridListItemOptions {
+ hasChildItems?: boolean
isVirtualized?: boolean
node: Node<unknown>
shouldSelectOnPressUp?: boolean
}@react-aria/tree/@react-aria/tree:AriaTreeGridListItemOptions AriaTreeGridListItemOptions {
+ hasChildItems?: boolean
node: Node<unknown>
shouldSelectOnPressUp?: boolean
}@react-spectrum/s2/@react-spectrum/s2:TreeItemContent+TreeItemContent {
+
+}@react-spectrum/tree/@react-spectrum/tree:TreeItemContent+TreeItemContent {
+
+}/@react-spectrum/tree:Collection+Collection <T extends {}> {
+ addIdAndValue?: boolean
+ children?: ReactNode | ({}) => ReactNode
+ dependencies?: ReadonlyArray<any>
+ idScope?: Key
+ items?: Iterable<{}>
+} |
reidbarber
approved these changes
Feb 12, 2025
devongovett
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
I think this is what https://github.com/orgs/adobe/projects/19/views/32?visibleFields=%5B%22Title%22%2C%22Assignees%22%2C%22Status%22%2C4406231%2C25365423%2C3244152%2C5195578%2C17851188%2C30557450%2C3404283%2C%22Labels%22%5D&filterQuery=&pane=issue&itemId=59197979
was asking for
The PR also removes some extraneous styles associated with borders for tree items since we aren't using them and it's better to not potentially bloat our CSS output with extra shorthands
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: