-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update TreeView API #7613
Open
snowystinger
wants to merge
5
commits into
s2-treeview
Choose a base branch
from
s2-treeview-api-update
base: s2-treeview
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+871
−635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## API Changes
react-aria-components/react-aria-components:UNSTABLE_Tree UNSTABLE_Tree <T extends {}> {
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
children?: ReactNode | ({}) => ReactNode
className?: string | ((TreeRenderProps & {
defaultClassName: string | undefined
})) => string
defaultExpandedKeys?: Iterable<Key>
defaultSelectedKeys?: 'all' | Iterable<Key>
dependencies?: Array<any>
- disabledBehavior?: DisabledBehavior = 'selection'
+ disabledBehavior?: DisabledBehavior = 'all'
disabledKeys?: Iterable<Key>
disallowEmptySelection?: boolean
expandedKeys?: Iterable<Key>
id?: string
onAction?: (Key) => void
onExpandedChange?: (Set<Key>) => any
onScroll?: (UIEvent<Element>) => void
onSelectionChange?: (Selection) => void
renderEmptyState?: (TreeEmptyStateRenderProps) => ReactNode
selectedKeys?: 'all' | Iterable<Key>
selectionBehavior?: SelectionBehavior
selectionMode?: SelectionMode
slot?: string | null
style?: CSSProperties | ((TreeRenderProps & {
defaultStyle: CSSProperties
})) => CSSProperties | undefined
} /react-aria-components:TreeProps TreeProps <T> {
aria-describedby?: string
aria-details?: string
aria-label?: string
aria-labelledby?: string
children?: ReactNode | (T) => ReactNode
className?: string | ((TreeRenderProps & {
defaultClassName: string | undefined
})) => string
defaultExpandedKeys?: Iterable<Key>
defaultSelectedKeys?: 'all' | Iterable<Key>
dependencies?: Array<any>
- disabledBehavior?: DisabledBehavior = 'selection'
+ disabledBehavior?: DisabledBehavior = 'all'
disabledKeys?: Iterable<Key>
disallowEmptySelection?: boolean
expandedKeys?: Iterable<Key>
id?: string
onAction?: (Key) => void
onExpandedChange?: (Set<Key>) => any
onScroll?: (UIEvent<Element>) => void
onSelectionChange?: (Selection) => void
renderEmptyState?: (TreeEmptyStateRenderProps) => ReactNode
selectedKeys?: 'all' | Iterable<Key>
selectionBehavior?: SelectionBehavior
selectionMode?: SelectionMode
slot?: string | null
style?: CSSProperties | ((TreeRenderProps & {
defaultStyle: CSSProperties
})) => CSSProperties | undefined
} /react-aria-components:TreeItemContentRenderProps TreeItemContentRenderProps {
allowsDragging?: boolean
hasChildRows: boolean
+ id: Key
isDisabled: boolean
isDragging?: boolean
isDropTarget?: boolean
isExpanded: boolean
isFocusVisible: boolean
isFocusVisibleWithin: boolean
isFocused: boolean
isHovered: boolean
isPressed: boolean
isSelected: boolean
level: number
selectionBehavior: SelectionBehavior
selectionMode: SelectionMode
+ state: TreeState<unknown>
} @react-aria/utils/@react-aria/utils:inertValue-inertValue {
- value?: boolean
- returnVal: undefined
-} @react-spectrum/s2/@react-spectrum/s2:TreeView+TreeView {
+ UNSAFE_className?: string
+ UNSAFE_style?: CSSProperties
+ aria-describedby?: string
+ aria-details?: string
+ aria-label?: string
+ aria-labelledby?: string
+ children?: ReactNode | (T) => ReactNode
+ defaultExpandedKeys?: Iterable<Key>
+ defaultSelectedKeys?: 'all' | Iterable<Key>
+ dependencies?: Array<any>
+ disabledBehavior?: DisabledBehavior = 'all'
+ disabledKeys?: Iterable<Key>
+ disallowEmptySelection?: boolean
+ expandedKeys?: Iterable<Key>
+ id?: string
+ isDetached?: boolean
+ isEmphasized?: boolean
+ items?: Iterable<T>
+ onAction?: (Key) => void
+ onExpandedChange?: (Set<Key>) => any
+ onSelectionChange?: (Selection) => void
+ renderEmptyState?: (TreeEmptyStateRenderProps) => ReactNode
+ selectedKeys?: 'all' | Iterable<Key>
+ selectionMode?: SelectionMode
+ slot?: string | null
+ styles?: StylesPropWithHeight
+} /@react-spectrum/s2:TreeViewItem+TreeViewItem <T extends {}> {
+ aria-label?: string
+ childItems?: Iterable<{}>
+ children: ReactNode
+ download?: boolean | string
+ hasChildItems?: boolean
+ href?: Href
+ hrefLang?: string
+ id?: Key
+ onHoverChange?: (boolean) => void
+ onHoverEnd?: (HoverEvent) => void
+ onHoverStart?: (HoverEvent) => void
+ ping?: string
+ referrerPolicy?: HTMLAttributeReferrerPolicy
+ rel?: string
+ routerOptions?: RouterOptions
+ target?: HTMLAttributeAnchorTarget
+ textValue: string
+ value?: T
+} /@react-spectrum/s2:TreeItemContent+TreeItemContent {
+
+} /@react-spectrum/s2:TreeViewProps+TreeViewProps {
+ UNSAFE_className?: string
+ UNSAFE_style?: CSSProperties
+ aria-describedby?: string
+ aria-details?: string
+ aria-label?: string
+ aria-labelledby?: string
+ children?: ReactNode | (T) => ReactNode
+ defaultExpandedKeys?: Iterable<Key>
+ defaultSelectedKeys?: 'all' | Iterable<Key>
+ dependencies?: Array<any>
+ disabledBehavior?: DisabledBehavior = 'all'
+ disabledKeys?: Iterable<Key>
+ disallowEmptySelection?: boolean
+ expandedKeys?: Iterable<Key>
+ id?: string
+ isDetached?: boolean
+ isEmphasized?: boolean
+ items?: Iterable<T>
+ onAction?: (Key) => void
+ onExpandedChange?: (Set<Key>) => any
+ onSelectionChange?: (Selection) => void
+ renderEmptyState?: (TreeEmptyStateRenderProps) => ReactNode
+ selectedKeys?: 'all' | Iterable<Key>
+ selectionMode?: SelectionMode
+ slot?: string | null
+ styles?: StylesPropWithHeight
+} /@react-spectrum/s2:TreeViewItemProps+TreeViewItemProps <T extends {} = {}> {
+ aria-label?: string
+ childItems?: Iterable<{}>
+ children: ReactNode
+ download?: boolean | string
+ hasChildItems?: boolean
+ href?: Href
+ hrefLang?: string
+ id?: Key
+ onHoverChange?: (boolean) => void
+ onHoverEnd?: (HoverEvent) => void
+ onHoverStart?: (HoverEvent) => void
+ ping?: string
+ referrerPolicy?: HTMLAttributeReferrerPolicy
+ rel?: string
+ routerOptions?: RouterOptions
+ target?: HTMLAttributeAnchorTarget
+ textValue: string
+ value?: T
+} @react-spectrum/toast/@react-spectrum/toast:ToastContainer ToastContainer {
aria-describedby?: string
aria-details?: string
aria-label?: string = "Notifications"
aria-labelledby?: string
- placement?: ToastPlacement
} /@react-spectrum/toast:SpectrumToastContainerProps SpectrumToastContainerProps {
aria-describedby?: string
aria-details?: string
aria-label?: string = "Notifications"
aria-labelledby?: string
- placement?: ToastPlacement
} @react-spectrum/tree/@react-spectrum/tree:TreeItemContent+TreeItemContent {
+
+} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
I think this is what https://github.com/orgs/adobe/projects/19/views/32?visibleFields=%5B%22Title%22%2C%22Assignees%22%2C%22Status%22%2C4406231%2C25365423%2C3244152%2C5195578%2C17851188%2C30557450%2C3404283%2C%22Labels%22%5D&filterQuery=&pane=issue&itemId=59197979
was asking for
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: