fix(Toast): resume timers if no longer over toast region after a toast is removed #7681
+52
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidbarber
changed the title
reidbarber
changed the title
reidbarber
changed the title
| } | ||
| } | ||
| prevToastCount.current = currentCount; | ||
| }, [ref, state]); |
There was a problem hiding this comment.
Suggested change
| }, [ref, state]); | |
| }, [ref, state.visibleToasts, state.resumeAll]); |
There was a problem hiding this comment.
eslint[react-hooks/exhaustive-deps] still wants state here 🤔
There was a problem hiding this comment.
huh.... ok then i guess, that's so weird
could always pull them off the state object beforehand, the unfortunate part is that the state object will likely always be new, at least, until the react compiler can run on that file
| return () => { | ||
| document.removeEventListener('pointermove', onPointerMove); | ||
| }; | ||
| }, [state.visibleToasts.length]); |
There was a problem hiding this comment.
Suggested change
| }, [state.visibleToasts.length]); | |
| }, [state.visibleToasts]); |
just in case there's some situation where one is removed and one is added at the same time?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7024
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: