chore: follow-up for rtl date/time format #7685
Open
+26
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuiliao
commented
Jan 30, 2025
| @@ -155,6 +155,10 @@ If the date field does not have a visible label, an `aria-label` or `aria-labell | |||
|
|
|||
| Note that most of this anatomy is shared with [TimeField](TimeField.html), so you can reuse many components between them if you have both. | |||
|
|
|||
| ### Internationalization | |||
There was a problem hiding this comment.
Rob suggested that it would be a good idea to leave some kind of information regarding the CSS changes needed to ensure the date/time format properly in RTL locales. I decided to add it like this but let me know if you have other opinions where it should go or contents that it should include.
snowystinger
previously approved these changes
Jan 30, 2025
yihuiliao
commented
Jan 31, 2025
| @@ -31,7 +31,7 @@ export function useFormatHelpText(props: Pick<SpectrumDatePickerBase<any>, 'desc | |||
| return ( | |||
| formatter.formatToParts(new Date()).map((s, i) => { | |||
| if (s.type === 'literal') { | |||
| return <span key={i}>{s.value}</span>; | |||
| return <span key={i}>{` ${s.value} `}</span>; | |||
There was a problem hiding this comment.
noticed in chromatic when i ran it on main. just need to add some extra spacing since that's what we had before
snowystinger
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: