Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5574] - add moveBefore and moveAfter to useTreeData #7689

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

rob-clayburn
Copy link
Contributor

Closes #5574

Add moveBefore (which looks to me like it is actually just an alias for move) and moveAfter methods to the useTreeData hook.

This is my first time submitting a PR to the project, so please let me know if I've got something wrong in the process!

✅ Pull Request Checklist:

  • [ ✅] Included link to corresponding React Spectrum GitHub Issue.
  • [✅ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • [ ✅] Filled out test instructions.
  • [✅] Updated documentation (if it already exists for this component).
  • [ n/a] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

I believe this is just internal atm - so running the new unit tests should be sufficient.

Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! You'll need to sign the CLA to get the build to pass.

@rob-clayburn
Copy link
Contributor Author

thanks - had to wait to get approval from my company. All good now and I've signed the agreement

Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, and thanks for the tests!

Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@reidbarber reidbarber added this pull request to the merge queue Jan 31, 2025
Merged via the queue into adobe:main with commit 1ba8f01 Jan 31, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add moveBefore and and moveAfter methods to useTreeData
3 participants