Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: ipad testing #7720

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

wip: ipad testing #7720

wants to merge 8 commits into from

Conversation

yihuiliao
Copy link
Member

@yihuiliao yihuiliao commented Feb 4, 2025

Found some issues on iPad in the Tailwind Examples on our docs and RAC Tailwind Storybook during testing.

Observations:

ios 18 testing results:
from testing session:

  • not terrible but focus ring issues occur intermittently (listbox, colorswatchpicker)
  • issues with selecting checkbox or toggling switch are non-existent

from this PR (60ms):

  • focus ring issues sometimes occur although less frequently than when timeout was 40ms
  • no issues with checkbox or switch

before usePress fix pr (#7677):

  • focus ring issues is persistent on listbox and colorswatchpicker
  • no issues with checkbox or switch

ios 17 testing results:
from testing session:

  • focus ring issue is persistent (listbox, colorswatchpicker)
  • cannot select checkbox or toggle switch (only present in storybook which includes both starter kits and the normal storybook. no issues with selection/toggling in docs or nextjs app)

from this PR:

  • focus ring issues sometimes occur although less frequently than when timeout was 40ms
  • no issues with checkbox or switch

before usePress fix pr (#7677):

  • focus ring issues are persistent
  • no issues with checkbox or switch but there's no animation when toggling the switch off

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Test using RAC examples and Tailwind Starter Kit:
https://reactspectrum.blob.core.windows.net/reactspectrum/8969816ac7a1ac851938d7f399590af84236e6c4/verdaccio/docs/index.html

🧢 Your Project:

@rspbot
Copy link

rspbot commented Feb 4, 2025

1 similar comment
@rspbot
Copy link

rspbot commented Feb 4, 2025

@rspbot
Copy link

rspbot commented Feb 5, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants