fix: drag & drop defaultId & disabled behavior #7812
Draft
+26
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7379 (comment)
Following up on the discoveries made in #7379, this PR forwards collection components
id
into dnd hooks. It also fixes keyboard issues found in testing where reordering would get stuck because of disabled keys at the boundaries of the collection.As a more general note, I feel like keyboard navigation of the
<DragIndicator />
could be improved significantly, especially in terms of communicating the visual position. Often times it behaves very unexpected at row boundaries or when encountering disabled items (e.g. displayed on the previous row while actually on next row "before").I'm not sure whether you guys have this on the roadmap already but otherwise I will see whether I can tackle that in another PR follow-up 👍
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: