fix: Environment with no FinalizationRegistry #7885
+12
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
reviewed
Mar 7, 2025
| idsUpdaterMap.delete(heldValue); | ||
| }); | ||
| let registry; | ||
| if (typeof window !== 'undefined' && window.FinalizationRegistry) { |
There was a problem hiding this comment.
Do we need to have a window? Some server environments might also have FinalizationRegistry but not have a window. Any problem with doing this?
Suggested change
| if (typeof window !== 'undefined' && window.FinalizationRegistry) { | |
| if (typeof FinalizationRegistry !== 'undefined') { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7882
We thought we could safely use this as every environment supports it
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/FinalizationRegistry
https://caniuse.com/?search=FinalizationRegistry
But it's not supported in CloudFlare workers. In that case though, every request should result in the complete throwing away of any previous request making the memory leak a non-issue.
If any other environments come along without this feature, they'll also have the problem, but given how long it took for it to be reported, maybe it's not that big of a deal.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: