fix: Fix virtualizer drag and drop with layout gaps #7886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowystinger
approved these changes
Mar 7, 2025
LFDanLu
reviewed
Mar 7, 2025
Comment on lines
+239
to
+240
| let yDist = Math.abs(candidate.rect.y - x); | ||
| let maxYDist = Math.abs(candidate.rect.maxY - x); |
There was a problem hiding this comment.
maybe I'm having a brain fart and not visualizing this quite right, but shouldn't this be candidate.rect.y - y instead? Like comparing the candidate's top/bottom edge's Y position with the current point to find the closest edge -> reiterating on the next candidate to find the candidate that is closest to the drop point?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using drag and drop reorder items in a grid or list with gaps between the items, the drop target would disappear when over the gap because we were looking for items under the mouse and there were none. This was broken by the recent refactor. Now instead of using
keyAtPoint, we get the items in a small rectangle that's as wide as the gap, and then find the closest item to the mouse position within that rectangle.