fix: Prevent submenus from closing on scroll #7894
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidbarber
approved these changes
Mar 7, 2025
|
I think that's an existing issue with usePreventScroll when there are text inputs in an overlay. In that case we apply a transform to the page to avoid browser scrolling, and I guess that causes the flash... |
LFDanLu
approved these changes
Mar 7, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the "Complex content" submenu example in the docs on iPad. This was closing due to a scroll event when the virtual keyboard appeared. Close on scroll is enabled for
isNonModalpopovers, but we should exclude submenus from this. Another reason to eventually split upisNonModalinto multiple props.Also fixed the search field overflowing the popover on iPad in that example.