Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Pass data attributes through on Toast #7923

Merged
merged 3 commits into from
Mar 14, 2025
Merged

Feat: Pass data attributes through on Toast #7923

merged 3 commits into from
Mar 14, 2025

Conversation

lukpsaxo
Copy link
Contributor

Closes #7916

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

N/A - unit tests should be enough?

🧢 Your Project:

Saxo Bank

@lukpsaxo lukpsaxo closed this Mar 13, 2025
@lukpsaxo lukpsaxo reopened this Mar 13, 2025
reidbarber
reidbarber previously approved these changes Mar 13, 2025
View reviewed changes
@reidbarber reidbarber added this pull request to the merge queue Mar 14, 2025
Merged via the queue into adobe:main with commit 74cac94 Mar 14, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snowystinger snowystinger snowystinger approved these changes

@reidbarber reidbarber reidbarber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RAC] Toast is not passing on data-* dom props
3 participants
@lukpsaxo @snowystinger @reidbarber