Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove full-icu #7933

Merged
merged 1 commit into from
Mar 18, 2025
Merged

chore: remove full-icu #7933

merged 1 commit into from
Mar 18, 2025
+1 −36

Conversation

snowystinger
Copy link
Member

Closes

Pretty sure we don't need this anymore
https://www.npmjs.com/package/full-icu

And it should make windows development easier.
https://github.com/adobe/react-spectrum/pull/7925/files

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Mar 14, 2025

Build successful! 🎉

@lukpsaxo lukpsaxo mentioned this pull request Mar 18, 2025
Merged
5 tasks
@snowystinger snowystinger added this pull request to the merge queue Mar 18, 2025
Merged via the queue into main with commit 1651867 Mar 18, 2025
30 checks passed
@snowystinger snowystinger deleted the chore-remove-full-icu branch March 18, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidbarber reidbarber reidbarber approved these changes

@yihuiliao yihuiliao yihuiliao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@snowystinger @rspbot @reidbarber @yihuiliao