Skip to content

fix(useTreeData): stale duplicate items when moving to root #8225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

reidbarber
Copy link
Member

@reidbarber reidbarber commented May 12, 2025

Fixes a RangeError: Maximum call stack size exceeded error that could be reproduced by doing the following operations in the RAC Tree DnD stories:

  1. Drag “Reports 1” to top of tree (above the first item)
  2. Drag “Reports” to top of tree (above the first item)

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented May 12, 2025

@reidbarber reidbarber added this pull request to the merge queue May 13, 2025
@reidbarber reidbarber mentioned this pull request May 13, 2025
5 tasks
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 13, 2025
@reidbarber reidbarber added this pull request to the merge queue May 13, 2025
Merged via the queue into main with commit 4893475 May 13, 2025
31 checks passed
@reidbarber reidbarber deleted the useTreeData-move-to-root-fix branch May 13, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants