Skip to content

docs: S2 Colors search #9163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
reidbarber merged 18 commits into from
Jan 14, 2026
Merged

docs: S2 Colors search #9163

reidbarber merged 18 commits into from
Jan 14, 2026
+1,078 −11

Conversation

@reidbarber
Copy link
Member

@reidbarber reidbarber commented Nov 10, 2025 •
edited
Loading

Adds Colors to the search menu.

Supports searching by name, or by hex code. When searching by hex code, it shows the closest colors and highlights the exact matches, or most similar matches. Pressing an item copies the color name.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Test the Colors section of the search menu

🧢 Your Project:

@LFDanLu
Copy link
Member

LFDanLu commented Nov 10, 2025

https://reactspectrum.blob.core.windows.net/reactspectrum/83863702ff3b9528a3b1e9499812796b51afd316/s2-docs/index.html

not sure why the build comment didn't come through

snowystinger
snowystinger previously approved these changes Nov 10, 2025
View reviewed changes
Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, pretty easy to use

LFDanLu
LFDanLu reviewed Nov 10, 2025
View reviewed changes
@snowystinger
Copy link
Member

snowystinger commented Dec 18, 2025

Are we going to continue moving this one forward? still seems useful

@reidbarber
Copy link
Member Author

reidbarber commented Dec 22, 2025

@snowystinger I'll be picking this back up now that the initial docs release is complete.

@rspbot
Copy link

rspbot commented Jan 9, 2026

Build successful! 🎉

@reidbarber reidbarber changed the title docs: S2 Colors search WIP: docs: S2 Colors search Jan 9, 2026
@reidbarber reidbarber changed the title WIP: docs: S2 Colors search docs: S2 Colors search Jan 9, 2026
@rspbot
Copy link

rspbot commented Jan 9, 2026

Build successful! 🎉

snowystinger
snowystinger reviewed Jan 9, 2026
View reviewed changes
snowystinger
snowystinger reviewed Jan 10, 2026
View reviewed changes
@rspbot
Copy link

rspbot commented Jan 12, 2026

Build successful! 🎉

@rspbot
Copy link

rspbot commented Jan 13, 2026

Build successful! 🎉

@reidbarber reidbarber enabled auto-merge January 14, 2026 16:29
@reidbarber reidbarber added this pull request to the merge queue Jan 14, 2026
Merged via the queue into main with commit ca4dfd3 Jan 14, 2026
32 checks passed
@reidbarber reidbarber deleted the s2-colors-search branch January 14, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LFDanLu LFDanLu LFDanLu left review comments

@snowystinger snowystinger snowystinger approved these changes

@yihuiliao yihuiliao yihuiliao approved these changes

Assignees

No one assigned

Labels

ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@reidbarber @LFDanLu @snowystinger @rspbot @yihuiliao