-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix(calendar): prevent setFocusedDate from stealing focus #9463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(calendar): prevent setFocusedDate from stealing focus #9463
Conversation
Signed-off-by: Aryan Bagade <[email protected]>
snowystinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! would you mind adding some tests for this so we don't have a regression later?
snowystinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the attempt, if you used AI, I think it mislead you. Your tests passed both before and after the change and didn't appear to have anything to do with the changes. I've removed them and added a test for the change.
|
Note to other reviewers, there is a usage in useRangeCalendarState's |
snowystinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked behaviour against Calendar/RangeCalendar month-and-year-pickers example as well
Closes #9427
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project:
Personal contribution (Author : Aryan Bagade aryan.com)