Skip to content

docs: fix scrolling in mobile search menu #9476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
reidbarber merged 2 commits into from
Jan 13, 2026
Merged

docs: fix scrolling in mobile search menu #9476

reidbarber merged 2 commits into from
Jan 13, 2026
+2 −2

Conversation

@reidbarber
Copy link
Member

@reidbarber reidbarber commented Jan 13, 2026

  • Fixed regression in docs: color scheme switcher #9403 where we added a Provider and forgot to set it full height.
  • Added background="layer-2" to index page's mobile search menu for consistency

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Open search menu on mobile and verify that you can scroll cards

🧢 Your Project:

@reidbarber reidbarber changed the title fix scrolling in mobile search menu docs: fix scrolling in mobile search menu Jan 13, 2026
@rspbot
Copy link

rspbot commented Jan 13, 2026

Build successful! 🎉

yihuiliao
yihuiliao approved these changes Jan 13, 2026
View reviewed changes
Copy link
Member

@yihuiliao yihuiliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested on my iphone

snowystinger
snowystinger approved these changes Jan 13, 2026
View reviewed changes
Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm tested on android

@reidbarber reidbarber added this pull request to the merge queue Jan 13, 2026
Merged via the queue into main with commit 1a30398 Jan 13, 2026
32 of 33 checks passed
@reidbarber reidbarber deleted the fix-mobile-search-menu-scrollin branch January 13, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snowystinger snowystinger snowystinger approved these changes

@yihuiliao yihuiliao yihuiliao approved these changes

Assignees

No one assigned

Labels

ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@reidbarber @rspbot @snowystinger @yihuiliao