docs: fix extra HTML end tags in docs build #9477
Merged
+165
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidbarber
changed the title
|
Build successful! 🎉 |
Member
snowystinger
left a comment
snowystinger
left a comment
There was a problem hiding this comment.
why is this actually happening? is it a bug in rsc-html-stream? or does that just make the existing issue worse?
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
reidbarber
changed the title
devongovett
approved these changes
Jan 14, 2026
Member
devongovett
left a comment
devongovett
left a comment
There was a problem hiding this comment.
Let's merge this with the verification script for a few days and see if it catches anything else. If not, we'll update rsc-html-stream with this patch.
snowystinger
approved these changes
Jan 14, 2026
Member
Author
|
Looks like that didn't fix it: https://app.circleci.com/pipelines/github/adobe/react-spectrum/31023/workflows/21159712-3276-4bc4-8cae-6bfd1c7bcb2a/jobs/568803 We can keep the script around until we do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is difficult to consistently reproduce, but occasionally in the S2 docs build, an extra
</script></body></html>is getting left in the HTML output.Example in production at: https://react-aria.adobe.com/examples/photos
(View page source and search
</script></body></html>)This seems like it might be due to the trailer being split across chunk boundaries in rsc-html-stream. This PR applies the fix from devongovett/rsc-html-stream#12 as a patch and adds a script that will fail the docs build if it detects the issue again.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: