Convert library modules to ES6 modules. #466
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dompuiu
commented
Feb 21, 2025
| vi: true, | ||
| }, | ||
| }, | ||
| rules: { | ||
| "unused-imports/no-unused-imports": "error", | ||
| "unused-imports/no-unused-vars": ["error", { argsIgnorePattern: "^_" }], | ||
| "ban/ban": [ |
There was a problem hiding this comment.
I removed the ban. I think it was used for Jasmine tests. Now we no longer have those. There is a vitest plugin (which we are already using) that will show warnings when you focus a test.
carterworks
approved these changes
Feb 21, 2025
|
When I updated Turbine I broke an existing extension. We might need to postpone this change for a period. |
jonsnyder
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Convert library modules to ES6 modules.
Related Issue
Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist: