Fix test timing to wait for view to be rendered before running expectations #467
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The configuration spec "initializes form fields with full settings", was consistently failing on my machine. I found that the problem was that the test runner was not waiting long enough after initializing the extension view controller before running expectations. I changed it so that it now waits for the rendered event before continuing. This caused a problem because when an error is thrown, the rendered event isn't triggered. I added a trigger for this in the error boundary. This uncovered a problem with one of the update variable tests. It was trying to verify that an error was not shown, but because it was checking too early it was succeeding even though the error would show if it waited until the view was rendered. I fixed this by updating a test to pull down mocked versions of the schema.
Related Issue
Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist: