Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore the background color to the original shade #471

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

carterworks
Copy link
Contributor

@carterworks carterworks commented Feb 27, 2025

Description

Before the update to @spectrum-css/tokens in #459 (not our actual change, just a representation of the color tokens)

.react-spectrum-provider {
  --spectrum-gray-100: rgb(248, 248, 248);
  background-color: var(--spectrum-gray-100);
}
image

Before this PR

.react-spectrum-provider {
  --spectrum-gray-100: rgb(233, 233, 233);
  background-color: var(--spectrum-gray-100);
}
image

After this PR:

.react-spectrum-provider {
  --spectrum-gray-50: rgb(248, 248, 248);
  background-color: var(--spectrum-gray-50);
}
image

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.
  • I've updated the schema in extension.json or no changes are necessary.
  • My change requires a change to the documentation.

@carterworks carterworks merged commit edb843d into main Feb 27, 2025
5 checks passed
@carterworks carterworks deleted the fix-spectrum-background branch February 27, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants