Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addClusterFacet: Add check for empty facetMatch #43

Merged
merged 3 commits into from
Jan 31, 2025
Merged

addClusterFacet: Add check for empty facetMatch #43

merged 3 commits into from
Jan 31, 2025

Conversation

asthabh23
Copy link
Member

Description

This PR adds check for empty returned value for facetMatch.
It also covers enabling filters for clusterFacet.

Related Issue

#42

Motivation and Context

This came up as a requirement while enabling use of clusterFacet for URL facet

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@asthabh23 asthabh23 requested a review from trieloff January 29, 2025 10:41
Copy link

This PR will trigger a patch release when merged.

@asthabh23 asthabh23 linked an issue Jan 29, 2025 that may be closed by this pull request
@trieloff
Copy link
Contributor

Thank you. This would be even better with a test.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.06%. Comparing base (85b5936) to head (37cda06).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   96.90%   97.06%   +0.16%     
==========================================
  Files          17       17              
  Lines        4750     4777      +27     
==========================================
+ Hits         4603     4637      +34     
+ Misses        147      140       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asthabh23 asthabh23 merged commit 8099709 into main Jan 31, 2025
7 checks passed
@adobe-bot
Copy link

🎉 This PR is included in version 1.16.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

addClusterFacet : add check for empty facetMatch
3 participants