Merged
Conversation
as the filters depend on the facet definitions, a facet reset should also reset the applicable filters
|
This PR will trigger a patch release when merged. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
+ Coverage 97.07% 98.29% +1.22%
==========================================
Files 17 17
Lines 4783 4820 +37
==========================================
+ Hits 4643 4738 +95
+ Misses 140 82 -58 ☔ View full report in Codecov by Sentry. |
asthabh23
approved these changes
Mar 5, 2025
|
🎉 This PR is included in version 1.16.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
addHistogramFacetandaddClusterFacetfunctions would run into issues if facets were reset, but existing filters stayed persisted. As filters are dependent on facets, resetting the filters should also reset the facets.