Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(facets): extract common facets as reusable facet definitions #6

Merged
merged 8 commits into from
Oct 11, 2024

Conversation

trieloff
Copy link
Contributor

No description provided.

Copy link

This PR will trigger a minor release when merged.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.74%. Comparing base (4f9e446) to head (3329e79).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   87.13%   89.74%   +2.61%     
==========================================
  Files          11       13       +2     
  Lines        3031     3453     +422     
==========================================
+ Hits         2641     3099     +458     
+ Misses        390      354      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trieloff trieloff requested a review from kptdobe October 10, 2024 13:50
@trieloff trieloff requested a review from karlpauls October 11, 2024 09:54
@trieloff trieloff merged commit 55d4b3b into main Oct 11, 2024
7 checks passed
@adobe-bot
Copy link

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants