refactor: remove cwvInterpolationFN, simpleCWVInterploationFN, INTERPOLATION_THRESHOLD from utils #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OLATION_THRESHOLD from utils
…OLATION_THRESHOLD from utils
|
This PR will trigger a minor release when merged. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
==========================================
+ Coverage 87.11% 87.87% +0.76%
==========================================
Files 11 11
Lines 3026 2994 -32
==========================================
- Hits 2636 2631 -5
+ Misses 390 363 -27 ☔ View full report in Codecov by Sentry. |
karlpauls
changed the title
trieloff
approved these changes
Oct 11, 2024
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The oversight ui currently uses cwvInterpolationFN, simpleCWVInterploationFN, and INTERPOLATION_THRESHOLD. The question is if we want to export them form utils. @trieloff, wdyt?