Added Skill for Building Blocks for EDS when AEM Sites Universal Editor is your Content Source#4
Closed
complexthings wants to merge 2 commits intoadobe:mainfrom
Closed
Conversation
shsteimer
reviewed
Mar 16, 2026
Collaborator
shsteimer
left a comment
There was a problem hiding this comment.
Sorry for delay on review...
In general, I think adding UE specific guidance is a good idea, but have some concerns:
- should his be a separate skill, or is it better (both in terms of usage and maintenance) as a set of UE specific resource files referenced from the existing building-blocks skill? I can see a case for both, but they seem to share a lot of the same core content, and I don't want to maintain in 2 places unless absolutely necessary, so lean towards the latter. Welcome your thoughts though.
- The skill adds a lot resources that would need to be maintained, which I think should be consolidated, or replaced by docs links where appropriate:
- replace example blocks with links to ue-block-collection
- remove things like field-naming-conventions and component-definition-organization, link to docs instead
- remove things covered better elsewhere such as css-tokens and resource-loading
- core skill file is over 700 lines, core guidance is to keep to under 500, can this be slimed down some?
- the
moveInstrumentationguidance appears multiple times in multiple forms. perhaps this could all be replaced with references to a canonical section?
- the
shsteimer
reviewed
Mar 16, 2026
| 1. **Project blocks** — `blocks/` directory in the current project | ||
| 2. **Block collections:** | ||
| - [AEM Block Collection (xwalk)](https://github.com/adobe-rnd/aem-block-collection-xwalk) — AEM Sites UE-enabled/xwalk blocks (preferred search starting point) | ||
| - [AEM Boileraplte Xwalk (xwalk)](https://github.com/adobe-rnd/aem-boilerplate-xwalk) — AEM Sites UE-enabled/xwalk boilerplate |
Collaborator
There was a problem hiding this comment.
Suggested change
| - [AEM Boileraplte Xwalk (xwalk)](https://github.com/adobe-rnd/aem-boilerplate-xwalk) — AEM Sites UE-enabled/xwalk boilerplate | |
| - [AEM Boilerplate Xwalk (xwalk)](https://github.com/adobe-rnd/aem-boilerplate-xwalk) — AEM Sites UE-enabled/xwalk boilerplate |
Author
|
Thanks @shsteimer the one I'm using locally has evolved similarly as well since I opened this. I forgot about this PR 😂 so I'm closing it, Looks like you all have other PRs coming in to handle this soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a new skill
building-blocks-xwalk-uefor building AEM Edge Delivery Services blocks when using AEM Sites Universal Editor (xwalk) as the content source. It includes workflow, as well as 2 example blocks (key-value configuration based block and nested block examples), and 11 resource documents covering common mistakes, component definition organization, configuration reading patterns, CSS tokens, data passing, field naming conventions, key-value migration, a migration guide, state management and troubleshooting.Related Issue
N/A - New contribution
Motivation and Context
When you're working with AEM Sites UE as your content-source the standard skills aren't entirely relevant, and documentation is dispersed between aem.live, experienceleague.adobe.com, the codebase, and in some cases undocumented, roll up your sleeves, just in general figuring it out yourself. I've had a skill rolling for a while, I stripped out my workflow specifics from it, made sure it aligned with the rest of your skills and was referencing them as best possible to remove any duplication.
How Has This Been Tested?
Screenshots (if appropriate):
N/A
Types of changes
Checklist: