feat: add HTL data-sly-test lint reference to best-practices#44
Open
bharat941 wants to merge 44 commits intoadobe:betafrom
Open
feat: add HTL data-sly-test lint reference to best-practices#44bharat941 wants to merge 44 commits intoadobe:betafrom
bharat941 wants to merge 44 commits intoadobe:betafrom
Conversation
Remove asset-manager and event-migration reference files that are no longer needed: - asset-manager.md, asset-manager-create.md, asset-manager-delete.md - event-migration-path-a.md, event-migration-path-b.md Keeping core migration patterns: scheduler, replication, resource-change-listener, event-migration
Expand AEM Cloud Service migration skill with additional patterns: - Asset Manager: create/upload (Direct Binary Access) + delete (HTTP Assets API) - Event Migration: JCR EventListener → EventHandler + JobConsumer (Path A & B) New reference files: - asset-manager.md, asset-manager-create.md, asset-manager-delete.md - event-migration-path-a.md, event-migration-path-b.md Made-with: Cursor
feat(aem): add asset-manager and event-migration patterns
…sistencies - Rewrite BPA section to use agent-native instructions instead of JavaScript helper scripts - Remove references to ./scripts/bpa-findings-helper.js and ./unified-collections/ - Fix Step 4 path references to use relative paths (references/ instead of .cursor/skills/...) - Update Available Patterns table to use correct references/ directory name - Remove CLI Testing section that referenced nonexistent scripts - Simplify Quick Reference to match new BPA flow without collection caching
Add list-projects API contract and enforce always presenting project list to the user for confirmation before calling fetch-cam-bpa-findings, even when only one project exists. Includes updated example agent flow.
Add detailed transformation references for scheduler, event-migration, replication, resource-change-listener, and asset-manager patterns including path classification, step-by-step instructions, and validation.
When fetch-cam-bpa-findings returns success: false, the skill now stops immediately and reports the error to the user. It no longer falls back to Manual Flow or CSV. Made-with: Cursor
Keep STOP ON MCP ERROR rule: when fetch-cam-bpa-findings returns success: false, stop immediately. Integrate with beta's source priority and list-projects flow. Made-with: Cursor
fix: stop on MCP error instead of falling back to Manual Flow
Replace code-migration with aem-cloud-service-best-practices (pattern refs, scr-to-osgi-ds, resource-resolver-logging) and migration/ (orchestration + scripts). Update marketplace and README.
Migration: cam-mcp reference, path alias, quick start, dual-plugin install notes, description tweaks. Best-practices: JCR observation vs OSGi EventHandler wording, prerequisites phrasing. Remove sibling terminology; plugin.json copy; safe CAM example id.
Add capability for local bpa csv file
Keep removal of code-migration/aem-migration; migration is under migration/aem-cloud-service-migration.
- Add references/data-sly-test-redundant-constant.md (Cloud SDK HTL lint) - Extend SKILL.md, README, plugin metadata for HTL/Sightly triggers Made-with: Cursor
…ipgrep Add Proactive discovery section with rg patterns to find likely redundant data-sly-test issues without a Maven build; extend front matter, When to Use, and Manual Pattern Hints. Compiler/build remains authoritative. Made-with: Cursor
Relocate the Cloud Service pattern package to skills/aem/cloud-service/skills/best-practices/ with SKILL.md and references/ at the plugin root (plugin id aem-best-practices). Move migration content out of the nested aem-cloud-service-migration folder into migration/ (plugin id aem-migration). Register aem-best-practices, aem-migration, aem-cloud-service-dispatcher, and aem-6-5-lts-dispatcher in .claude-plugin/marketplace.json. Update the repository README with install commands and the revised directory layout. Migration and CAM docs require explicit CAM project confirmation, verbatim MCP errors with no automatic fallback, and IDE workspace-scoped file discovery. Docs use aem-prefixed plugin names without extra marketplace commentary.
…/htl-reference-in-best-practices Resolve conflicts: consolidate skill under skills/best-practices (aem-best-practices), keep HTL reference + proactive ripgrep discovery in SKILL.md, drop legacy aem-cloud-service-best-practices plugin wrapper. Update plugin README and keywords for HTL/Sightly. Made-with: Cursor
…path, point to references/ and SKILL.md Made-with: Cursor
…nsolidation Aem cloud best practices skill consolidation
…nsolidation docs(migration): document CAM MCP enablement restriction verbatim errors
- Root npm test: skills-ref validate, migration unit tests, marketplace JSON parse - CI validate workflow runs npm test - SKILL frontmatter name must match folder (best-practices, migration) per skills-ref - Fixture CSV + node:test coverage for getBpaFindings and checkAvailableSources
…t-practices scope
…ranch Remove references/osgi-cfg-json-cloud-manager.md and all SKILL.md wiring (quick start, delegation, when-to-use). Keeps CAM/MCP tightening, workspace scope, and MCP error handling from refactoring.
Tighter fallback rules and error handling
…to SCR→DS module Ensure the agent only removes POM dependencies whose API was actually migrated in source code, and verifies zero remaining imports via rg before any deletion. Made-with: Cursor
…n guard to SCR→DS module" This reverts commit ed1c69f.
Add HTL data-sly-test lint reference to aem-cloud-service-best-practices
- New: references/data-sly-test-redundant-constant.md for Cloud SDK HTL lint - Updated SKILL.md with HTL workflow, proactive rg discovery, pattern table entry - Updated README.md to mention HTL reference module Made-with: Cursor
feat(best-practices): add HTL data-sly-test lint reference
bharat941
changed the title
The SKILL.md description field is used by agents to match user requests to skills. Add HTL Cloud SDK lint (data-sly-test redundant constant) so the skill is discovered for HTL tasks alongside Java/OSGi patterns. Made-with: Cursor
… consistent pattern Move the HTL-specific workflow and proactive discovery sections from SKILL.md into references/data-sly-test-redundant-constant.md so HTL follows the same generic pattern as all other modules (table row + self-contained reference file). Made-with: Cursor
Add HTL data-sly-test lint as a first-class pattern in the migration skill, matching how scheduler/replication/eventListener are referenced. Includes quick-start row, starter prompt, Step 1 pattern id, dedicated htlLint flow section, and notes that it uses rg discovery instead of BPA/CSV/MCP. Made-with: Cursor
fix(best-practices): add HTL/Sightly to front matter description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an HTL
data-sly-testlint reference module to theaem-cloud-servicebest-practices skill. This provides pattern-based fix guidance for the AEM Cloud SDK HTL lint warning "data-sly-test: redundant constant value comparison" and a proactive ripgrep discovery workflow to find candidates without a Maven build.Changes across 3 files:
references/data-sly-test-redundant-constant.md(259 lines) — covers boolean literal, raw path string, numeric, and split-expression patterns with before/after examplesSKILL.md— adds HTL (Sightly) workflow section, proactivergdiscovery patterns, and a pattern table entry for HTL lintREADME.md— mentions the new HTL reference module in the skill summaryRelated Issue
Re-applies the changes from PR #5 which were lost when the fork was synced to
adobe/skills:betaupstream.Motivation and Context
The AEM Cloud SDK build emits HTL lint warnings for redundant constant value comparisons in
data-sly-testattributes. Without a reference module, the agent has no structured guidance for classifying and fixing these warnings. This change gives the best-practices skill full HTL lint coverage alongside its existing Java/OSGi patterns.How Has This Been Tested?
data-sly-test-redundant-constant.mdexists underskills/aem/cloud-service/skills/best-practices/references/SKILL.mdcontains the HTL workflow section, proactive discovery table, and pattern table entryREADME.mdmentions the HTL referenceScreenshots (if appropriate):
N/A — documentation/skill reference changes only.
Types of changes
Checklist: