Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sites): update hlxConfig via API #707

Merged
merged 1 commit into from
Jan 17, 2025
Merged

fix(sites): update hlxConfig via API #707

merged 1 commit into from
Jan 17, 2025

Conversation

ekremney
Copy link
Member

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description. Or if there's no issue created, make sure you
    describe here the problem you're solving.
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

If the PR is changing the API specification:

  • make sure you add a "Not implemented yet" note the endpoint description, if the implementation is not ready
    yet. Ideally, return a 501 status code with a message explaining the feature is not implemented yet.
  • make sure you add at least one example of the request and response.

If the PR is changing the API implementation or an entity exposed through the API:

  • make sure you update the API specification and the examples to reflect the changes.

If the PR is introducing a new audit type:

  • make sure you update the API specification with the type, schema of the audit result and an example

Related Issues

Thanks for contributing!

@github-actions GitHub Actions
Copy link

This PR will trigger a patch release when merged.

dzehnder
dzehnder approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@dzehnder dzehnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also approved by @alinarublea

AndreiAlexandruParaschiv
AndreiAlexandruParaschiv approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@AndreiAlexandruParaschiv AndreiAlexandruParaschiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ekremney ekremney merged commit 1f42265 into main Jan 17, 2025
5 checks passed
@ekremney ekremney deleted the update-hlx-config branch January 17, 2025 15:51
solaris007 pushed a commit that referenced this pull request Jan 17, 2025
@semantic-release-bot
chore(release): 1.86.6 [skip ci]
e1b553f 
## [1.86.6](v1.86.5...v1.86.6) (2025-01-17)

### Bug Fixes

* **sites:** update hlxConfig via API ([#707](#707)) ([1f42265](1f42265))
@solaris007
Copy link
Member

🎉 This PR is included in version 1.86.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzehnder dzehnder dzehnder approved these changes

@AndreiAlexandruParaschiv AndreiAlexandruParaschiv AndreiAlexandruParaschiv approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ekremney @solaris007 @dzehnder @AndreiAlexandruParaschiv